This repository has been archived by the owner on Dec 12, 2023. It is now read-only.
check-running-kernel: Add support for ZSTD compression #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
commented
Mar 12, 2022
amotl
force-pushed
the
amo/improve-running-kernel
branch
from
623673d to
112b0f2
Compare
amotl
force-pushed
the
amo/improve-running-kernel
branch
from
112b0f2 to
f97a119
Compare
amotl
changed the title
This was referenced Mar 13, 2022
|
I can confirm this issue |
waja
suggested changes
Mar 31, 2022
There was a problem hiding this comment.
Hi,
while the change seems to be fine, the zstd binary is needed to work. Maybe you can also adjust the following in your changes?
if ! which ${filter%% *} >/dev/null; then
echo "UNKNOWN: filter command '$filter' missing, perhaps install xz-utils, lz4 or lzop?" >&2
exit $UNKNOWN
fi
Thanks, Jan.
|
Superseeded by #94 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Bernd and Jan,
first things first: Thanks a stack for conceiving and maintaining this collection of fine monitoring plugins.
As this is our very first contribution to Debian, please bear with us 1. We recently discovered the
check_running_kernelprogram and are now running it on 40+ machines. This is not that much, but it was enough diversity to give us the opportunity to discover some minor shortcomings, mostly on machines running derivate, non-vanilla Debian distributions like Proxmox and Ubuntu.Secondly, we discovered that on the same Proxmox machine, and on another vanilla Ubuntu 20.04 machine, both running 5.x Linux kernel versions, there was a suffix added to the on-disk kernel image, which we stripped off usingI've diverted this topic to check-running-kernel: Compensate for CONFIG_VERSION_SIGNATURE suffix #92 in order to keep things separate.sedin order to satisfy the comparison operation. You can find more details about this topic in the comment section below.We hope you like those improvements and ask you to let us know about any adjustments you would like to see.
With kind regards,
Andreas.
/cc @Tonkenfo
Footnotes
While we just also signed up to https://salsa.debian.org/, we discovered this repository also on GitHub and found that both of you might be exchanging patches between here and https://salsa.debian.org/nagios-team/pkg-nagios-plugins-contrib already. So, we are submitting this patch to this repository. If this is wrong, please advise different places where to submit this patch. ↩